search

bigcartel / dugway

Easily build and test Big Cartel themes.
https://developers.bigcartel.com/api/themes
MIT License
149 stars 22 forks source link

Dugway lacks ES6 support when building #167

Closed starzonmyarmz closed 5 years ago

starzonmyarmz commented 5 years ago

When attempting to build my theme using dugway build, it bombs when trying to Uglify the JS: https://gist.github.com/starzonmyarmz/a62595c807b1781e873c793bc7cd3df7. It appears the version of Uglifier dependency is pretty far behind. Current version is 4.2, while Dugway relies on 1.3. Bumping the dependency might just fix it. It would make me very very happy if @brettchalupa were to take a look at this 😉.

brettchalupa commented 5 years ago

@starzonmyarmz thanks for logging this and all the context. Let me see what I can do about updating the dependency and testing ES6. (Also, flashback seeing your username come through in the notification! 😄)

starzonmyarmz commented 5 years ago

brendan-fraser-drunk-clap

brettchalupa commented 5 years ago

@starzonmyarmz if you run gem update dugway that should install v0.11.4, which supports ES6. Let me know if you run into any issues!

starzonmyarmz commented 5 years ago

Works great @brettchalupa! Thanks for the speedy turnaround!