bigcartel / dugway

Easily build and test Big Cartel themes.
https://developers.bigcartel.com/api/themes
MIT License
149 stars 22 forks source link

BigDecimal.new is deprecated warnings #170

Closed starzonmyarmz closed 4 years ago

starzonmyarmz commented 4 years ago

I recently updated the Dugway gem to 0.12.0 and now when running dugway server I get the following warnings in my Terminal:

/Library/Ruby/Gems/2.6.0/gems/dugway-0.12.0/lib/dugway/liquid/filters/util_filters.rb:95: warning: BigDecimal.new is deprecated; use BigDecimal() method instead.

Thoughts? Is this an isolated issue, or something you're already aware of?

brettchalupa commented 4 years ago

Thanks for the heads up @starzonmyarmz! I believe this has to do a new deprecation when using Ruby 2.6.0. I've got a fix brewing in https://github.com/bigcartel/dugway/pull/171. I'll drop a note here when I close the issue when a new gem is cut and pushed to rubygems.org.

starzonmyarmz commented 4 years ago

Awesome! Thanks Brett!

On Tue, Nov 5, 2019 at 6:02 PM Brett Chalupa notifications@github.com wrote:

Thanks for the heads up @starzonmyarmz https://github.com/starzonmyarmz! I believe this has to do a new deprecation when using Ruby 2.6.0. I've got a fix brewing in #171 https://github.com/bigcartel/dugway/pull/171. I'll drop a note here when I close the issue when a new gem is cut and pushed to rubygems.org.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bigcartel/dugway/issues/170?email_source=notifications&email_token=AABJ23362K3V5WTZID3X3T3QSH3QRA5CNFSM4JJKGDHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDEUWNY#issuecomment-550062903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABJ23ZWMOWBLFDO545JWQLQSH3QRANCNFSM4JJKGDHA .

brettchalupa commented 4 years ago

@starzonmyarmz fix for this is in the latest version of the gem. gem install dugway will do the trick. The fix is in version 0.12.1. dugway version will let you know what you've got installed locally. Let us know if you run into any issues!

starzonmyarmz commented 4 years ago

Works great! Thanks again, @brettchalupa!