search

bigcartel / dugway

Easily build and test Big Cartel themes.
https://developers.bigcartel.com/api/themes
MIT License
149 stars 22 forks source link

Remove contact tabindex #172

Closed cella closed 4 years ago

cella commented 4 years ago

Fixes https://www.pivotaltracker.com/story/show/169763821

Accessibility best practices dictate that elements should not have tabindex greater than zero. Using tabindex with a value greater than 0 creates an unexpected tab order, making the page less intuitive and can give the appearance of skipping certain elements entirely. This removes tabindex from the contact fieldds and relies on the page's default tab order.

Resources: https://dequeuniversity.com/rules/axe/3.3/tabindex?application=AxeChrome

cella commented 4 years ago

Hey @hwinn4! Yes, the "Send Message" tabindex will have to be addressed in the theme code itself since that's hardcoded in there. I don't think this is ready to merge until we are ready to push our accessibility work to production, so I'll put a DO NOT MERGE flag on here but for local testing, we should pull this branch down in order to pick up the dugway changes locally.

cella commented 4 years ago

Actually, I just created an accessibility-improvements feature branch that we can push any dugway changes into.

cella commented 4 years ago

After talking with @nickendle, we're going to hold off on making changes to tabindex due to the implications it has on storefront and older themes. Closing this for now.