bigcartel / dugway

Easily build and test Big Cartel themes.
https://developers.bigcartel.com/api/themes
MIT License
149 stars 22 forks source link

Pin BigDecimal to 1.4.x to allow for Liquid 3.x.x #to_number to work #186

Closed brettchalupa closed 3 years ago

brettchalupa commented 3 years ago

Modern Rubies change how BigDecimal is instantiated, which conflicts with Liquid 3.x.x's approach: https://github.com/Shopify/liquid/blob/v3.0.6/lib/liquid/standardfilters.rb#L296

For the time being, until we upgrade Liquid across all of Big Cartel, this pins BigDecimal to a working version.

Also, for the time being, we're limited to certain Rubies based off of https://github.com/ruby/bigdecimal#which-version-should-you-select

Fixes https://github.com/bigcartel-themes/ranger/issues/6