bigchaindb / bigchaindb-driver

Official Python driver for BigchainDB
https://www.bigchaindb.com
Apache License 2.0
105 stars 104 forks source link

transaction status call missing from the latest driver #419

Closed agwego closed 6 years ago

agwego commented 6 years ago

The trnasaction.status call is missing from the driver.

vrde commented 6 years ago

Hi @agwego, when you send a transaction to the network, the driver will wait for that transaction to be included in a block (this is true since version 0.5.0a2). If there is a problem, than the call will raise an exception.

I'll keep this issue open so we remember to be more explicit in the documentation and examples.

agwego commented 6 years ago

That's fine, but why remove the call, and break peoples code.

ttmc commented 6 years ago

Quoting from my blog post about changes to the HTTP API in BigchainDB 2.0:

The transaction status endpoint was removed because one can get information about a transaction’s status by using the mode parameter in the POST /transactions endpoint (explained above), and also by subscribing to the WebSocket Event Stream API. A new issue was created to consider adding a new transaction status endpoint. If that’s something you really need, please comment on that issue to explain why.

Remember, BigchainDB is open source! If you want something, you can just add it (or convince someone else to add it), and you can share it with everyone by creating a pull request. We have some docs about Contributing to BigchainDB.

agwego commented 6 years ago

You're missing the point.

I have code in production against BigchainDB 1.3, I'm in the process of migrating that code to 2.X, I now have to make the decision do I branch my code which is annoying, or work around the issue, because you changed the API and now my code doesn't work with 2.X. This includes Python, Java, Node.js code bases. I've tweaked your codebase quite a bit, because your logging leaves a lot to be desired.

Feel free to close this.

codegeschrei commented 6 years ago

Hey @agwego I've opened a PR to show how to check for the status of a transaction. If you're interested you can give some feedback.