Closed ttmc closed 4 years ago
Merging #293 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #293 +/- ##
=======================================
Coverage 95.14% 95.14%
=======================================
Files 12 12
Lines 309 309
=======================================
Hits 294 294
Misses 15 15
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ba81d1b...667e2c9. Read the comment docs.
I realized I forgot to include the signed-off-by line in the Git commit messages, so I will see if I can fix those.
I had to do a force-push of the revised commits, but it looks like it worked. Disaster averted!
Perfect. Will review asap I do have a minute
On Thu, 23 May 2019, 09:23 Troy McConaghy, notifications@github.com wrote:
I had to do a force-push of the revised commits, but it looks like it worked. Disaster averted!
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/bigchaindb/js-bigchaindb-driver/pull/293?email_source=notifications&email_token=AAM76SF4NWKM6PLYXS4OIFDPWZA5JA5CNFSM4HOUAL4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWBJ3WA#issuecomment-495099352, or mute the thread https://github.com/notifications/unsubscribe-auth/AAM76SFWHV7AXQZQHPWSPZDPWZA5JANCNFSM4HOUAL4A .
release-it
latest version is now 12.4.1 but everything should work as well with 12.2.0.
Since a lot of packages needs to be updated this can be done in another PR, therefore I will approve it.
This is to help with issue #292
RELEASE_PROCESS.md
file based on:release-it
based on the same options in oceanprotol/commons, i.e. inpackage.json
I hope the process is mostly correct. I wasn't able to test it. Please take a look to make sure it makes sense. Once someone uses it, they might find something that should be changed or clarified.