search

bigcommerce / big-design

Design system that powers the BigCommerce ecosystem.
https://bigcommerce.github.io/big-design
Other
47 stars 65 forks source link

fix(component): PillTabs no longer submit form #1574

Closed bobbyshaw closed 1 month ago

bobbyshaw commented 1 month ago

What?

Ensure PillTabs use buttons of type button rather than submit

Why?

This resolves #1573 so that using PillTabs do not submit any form they are contained by.

Testing/Proof

Manually tested by wrapping PillTabs in a form and ensuring it is no longer submitted.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: e5302a4897743bd746aadb976c5ae19190bd4daf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR