Some responses incorrectly throw error messages because there is a type mismatch on the arguments to the error constructors. Basically, json_decode on the response body is not guaranteed to return a string. We need to enforce the string.
Writing test cases involved a lot of work unless a curl abstraction was built/used. Even mocking is extremely difficult here.
carsonreinke
commented
4 years ago
What?
Some responses incorrectly throw error messages because there is a type mismatch on the arguments to the error constructors. Basically,
json_decodeon the response body is not guaranteed to return a string. We need to enforce the string.Writing test cases involved a lot of work unless a curl abstraction was built/used. Even mocking is extremely difficult here.
Tickets / Documentation
https://github.com/bigcommerce/bigcommerce-api-php/issues/223
Screenshots (if appropriate)
None
cc @jofomah