bigcommerce / bigcommerce-api-php

Connect PHP applications with the Bigcommerce Platform
https://developer.bigcommerce.com
MIT License
143 stars 186 forks source link

Add api_url and login_url config options #293

Closed rtalvarez closed 11 months ago

rtalvarez commented 11 months ago

What?

Screenshots (if appropriate)

No screenshots to attach, but I have tested these changes in my consumer app via composer require "bigcommerce/api @dev" and verified the right URLs are being used:

If no custom URLs are provided, https://api.bigcommerce.com and https://login.bigcommerce.com are used. If custom URLs are provided, those are being used

rtalvarez commented 11 months ago

LGTM.

@bookernath I wouldn't rename anything, because the proposed names are consistent with class members and comments used around the code.

Thanks for the pointers, makes sense, I'll leave as is then

Would you mind merging this for me if you have access? It looks like I don't have write access around this side of town. Also not sure if the process for cutting a new release is documented anywhere, I'd be interested in publishing a bump with these changes 👀