bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
91 stars 64 forks source link

refactor(core): remove Popover component #1232

Closed jorgemoya closed 1 month ago

jorgemoya commented 1 month ago

What/Why?

Builds of #1231, removes Popover component in favor of using radix primitives.

Testing

Locally.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 3cd3af78beb9bdba3f7f1d74a278151e7b52d51b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------- | ----- | | @bigcommerce/catalyst-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 7:23pm
6 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst/Faegdu3g9HALhFC5yEYk2EdwrbNS)) | | | Aug 6, 2024 7:23pm | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/8ZZ5fXcNhY29nj6W9BfRNtgwHQ9z)) | [Visit Preview](https://catalyst-1millionproducts-store-git-6867e5-bigcommerce-platform.vercel.app) | | Aug 6, 2024 7:23pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/7GhtjUc16hf6LqRVCFCJJ5T3MS6k)) | [Visit Preview](https://catalyst-au-git-remove-popover-bigcommerce-platform.vercel.app) | | Aug 6, 2024 7:23pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/5F5Jg5BjWiBEvxPD9X8eRTEFkTYN)) | [Visit Preview](https://catalyst-test-store-git-remove-popover-bigcommerce-platform.vercel.app) | | Aug 6, 2024 7:23pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/CkiYjTT41AypQkxXnkC9RyssXguw)) | [Visit Preview](https://catalyst-uk-git-remove-popover-bigcommerce-platform.vercel.app) | | Aug 6, 2024 7:23pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/DGyFhGuam9bNL1R8aRK4vczXmoFE)) | [Visit Preview](https://catalyst-unstable-git-remove-popover-bigcommerce-platform.vercel.app) | | Aug 6, 2024 7:23pm |
github-actions[bot] commented 1 month ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-404xckpma-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 85
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 87
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85