search

bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
91 stars 64 forks source link

fix: type for slideshow should not include ref #1238

Closed matthewvolk closed 1 month ago

matthewvolk commented 1 month ago

What/Why?

Since slideshow handles its own ref internally, and we do not use a ref passed from props, we can use ComponentPropsWithoutRef when defining the props for slideshow. This also makes it easier to register in Makeswift.

Testing

N/A

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 427a41f9bd77a7562c1d8765feeb3c9900ccf3bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 4:05pm
6 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst/9QVEh1XkxZHgvxVFWibCddxqv5W5)) | | | Aug 7, 2024 4:05pm | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/3UtomqyR9nvu4gnHGEsyHDQYHAH7)) | | | Aug 7, 2024 4:05pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/GRiE4SsxxnfQEfbzxKpTGD6qA1eJ)) | | | Aug 7, 2024 4:05pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/EPB9qF7FSJPEG9a8ksRnu8SBRNdR)) | | | Aug 7, 2024 4:05pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/AxGE76tdXrA2BJTnHweyTyZRL2D1)) | | | Aug 7, 2024 4:05pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/i8UwXWvxAbAYNVzBDvUZuWzCcUPE)) | | | Aug 7, 2024 4:05pm |