bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
91 stars 64 forks source link

fix(cli): single source of truth for manifest schema #1242

Closed matthewvolk closed 1 month ago

matthewvolk commented 1 month ago

What/Why?

Mistakenly, the applyIntegrations utility function was not updated to reflect the new shape of the integration manifest.json file, so it failed during consumption. This PR defines a single Manifest schema with zod and uses it as a single source of truth for all references to manifest throughout the CLI.

Testing

Testing built CLI:

https://github.com/user-attachments/assets/567eb4be-e89b-46d4-a117-071e36cd3cc4

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 7:56pm
6 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst/FEKS9zWJncUhXqgNG9USKr9Bv2FJ)) | | | Aug 8, 2024 7:56pm | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/3B4yEQar6ovqYe3oCAXFBx9QCctX)) | | | Aug 8, 2024 7:56pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/339V7Xfoa9wRay5U45DCKhkzfkeU)) | | | Aug 8, 2024 7:56pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/CBP8TSdEawYwwvUW953WsMTBTmY3)) | | | Aug 8, 2024 7:56pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/JEDmMgDm9gppzbx6PogEz8PBK3qW)) | | | Aug 8, 2024 7:56pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/7G3BpwGUU6rmhii1TtrAyN6DWKLy)) | | | Aug 8, 2024 7:56pm |
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 22a4400ae0e8de23bcadc2f78e1e7712df3cccc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------------- | ----- | | @bigcommerce/create-catalyst | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-jru87vk2c-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 77
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 78
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85