bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
91 stars 64 forks source link

fix(chore): Fetch pull request details at the start #1255

Closed avattipalli closed 1 month ago

avattipalli commented 1 month ago

What/Why?

It looks like find_pull_request on lighthouse audit workflow doesn't finish and make the output available before the next step(comment_to_pr) is looking for the result. Moving the step to a few steps above to make the output readily available should fix the failing workflow due to this.

Testing

CI results.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 9:04pm
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 9:04pm
5 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/DR5qoC4dCPCPybqr1kHjuEQvYBF8)) | [Visit Preview](https://catalyst-1millionproducts-store-git-b9681b-bigcommerce-platform.vercel.app) | | Aug 12, 2024 9:04pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/6q3dfbx1shZTiHp4FvcSby7SHbKt)) | [Visit Preview](https://catalyst-au-git-lhworkflow-bigcommerce-platform.vercel.app) | | Aug 12, 2024 9:04pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/BYAmFAbqQF3MF7p1NHc5a4mJoDXh)) | [Visit Preview](https://catalyst-test-store-git-lhworkflow-bigcommerce-platform.vercel.app) | | Aug 12, 2024 9:04pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/HVEp1KvhEpk4Hpe9czvFYFAcqqDF)) | [Visit Preview](https://catalyst-uk-git-lhworkflow-bigcommerce-platform.vercel.app) | | Aug 12, 2024 9:04pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/FKjQKEJaWoYyTWujdbzeacrqhRiG)) | [Visit Preview](https://catalyst-unstable-git-lhworkflow-bigcommerce-platform.vercel.app) | | Aug 12, 2024 9:04pm |
changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: d483e8aafd191132cd5b7d47b2dd4545e0ac9dbf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 1 month ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-cww7t753i-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 93
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 95
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85