bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
91 stars 64 forks source link

refactor: progressive improvements to prop APIs #1256

Closed jorgemoya closed 1 month ago

jorgemoya commented 1 month ago

What/Why?

We found areas of opportunities for the new prop APIs, most of the work in this PR includes refactoring the APIs to include these enhancements and to provide a better standard for our component's props.

Testing

Locally.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 6:26pm
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 6:26pm
5 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/FzNcP6PbDvM2Hx4XS2ShpQhiCEJn)) | [Visit Preview](https://catalyst-1millionproducts-store-git-f0b07e-bigcommerce-platform.vercel.app) | | Aug 14, 2024 6:26pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/FZe3mWpvP78CK8kuLcYSsiQrUZ1H)) | [Visit Preview](https://catalyst-au-git-standarize-props-bigcommerce-platform.vercel.app) | | Aug 14, 2024 6:26pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/qCYiBKsFwo49AwgK5w1MNvVYjP1b)) | [Visit Preview](https://catalyst-test-store-git-standarize-props-bigcommerce-platform.vercel.app) | | Aug 14, 2024 6:26pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/FMT8DmkdMDEd8RaWcKAxskZLGLNm)) | [Visit Preview](https://catalyst-uk-git-standarize-props-bigcommerce-platform.vercel.app) | | Aug 14, 2024 6:26pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/3DhmxDaH21QMfsqnxeERAyS9BqYA)) | [Visit Preview](https://catalyst-unstable-git-standarize-props-bigcommerce-platform.vercel.app) | | Aug 14, 2024 6:26pm |
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 78274ad45d8fb40127a377b71caf15a54f4fced2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------- | ----- | | @bigcommerce/catalyst-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-9t8ssv185-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 87
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85