bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
91 stars 64 forks source link

chore(functional): Send notifications only on open pr #1271

Closed avattipalli closed 4 weeks ago

avattipalli commented 4 weeks ago

What/Why?

We want to send notifications on test runs only for open pull requests to cut down the nosie from draft pr's.

Testing

Notifications are sent for a pull request in open state

Screenshot 2024-08-16 at 10 39 44 AM

Notifications are skipped for a pull request in draft state

Screenshot 2024-08-16 at 10 31 30 AM
vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 3:52pm
7 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst/5ZAkhYLMXzi4G7eeQNThra7tbpRA)) | | | Aug 16, 2024 3:52pm | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/BiNzYuLMvD9L39ihcRiLeAjZXrGq)) | [Visit Preview](https://catalyst-1millionproducts-store-git-a9ca4d-bigcommerce-platform.vercel.app) | | Aug 16, 2024 3:52pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/8VDNRdM47DuhtmbySXH4H8dgrJVu)) | [Visit Preview](https://catalyst-au-git-contextpr-bigcommerce-platform.vercel.app) | | Aug 16, 2024 3:52pm | | **catalyst-integration-customer-access-token** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-integration-customer-access-token/92Vst5VMFWdRoM24W5r7DLddr66p)) | [Visit Preview](https://catalyst-integration-customer-a-git-94c148-bigcommerce-platform.vercel.app) | | Aug 16, 2024 3:52pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/3ZTFw2BHb5eXxs7sJScj5EnZ5YeU)) | [Visit Preview](https://catalyst-test-store-git-contextpr-bigcommerce-platform.vercel.app) | | Aug 16, 2024 3:52pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/FmsEoT2xbsEBuqhD76WMfwLwxF7a)) | [Visit Preview](https://catalyst-uk-git-contextpr-bigcommerce-platform.vercel.app) | | Aug 16, 2024 3:52pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/A4tkgNGYUSsMVvGMLDy5boGDMPMC)) | [Visit Preview](https://catalyst-unstable-git-contextpr-bigcommerce-platform.vercel.app) | | Aug 16, 2024 3:52pm |
changeset-bot[bot] commented 4 weeks ago

⚠️ No Changeset found

Latest commit: 15b74b8d8b89ca4d0c2af70206e4669323c9e85e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jorgemoya commented 4 weeks ago

Can you a description to this PR? 🙏

avattipalli commented 4 weeks ago

Can you a description to this PR? 🙏

Sorry! I was testing sending notifications only if a PR is open and when a job fails so I was flipping it's status. I will update it once I have tested all the cases.

github-actions[bot] commented 4 weeks ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-c14u9bahm-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 84
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85