search

bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
110 stars 119 forks source link

refactor(middleware): split with-routes #1318

Closed deini closed 2 months ago

deini commented 2 months ago

What/Why?

This PR splits the with-routes middleware into 3:

This simplifies with-routes and allows us to remove the locale var we were mutating/accessing all over the place.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 10:29pm
7 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst/2AGBshgSFKraPKokzbz9ZQHE3Kvd)) | | | Aug 29, 2024 10:29pm | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/C9xsEoJ2mVy7jqGpoyK9nGyJe3u3)) | [Visit Preview](https://catalyst-1millionproducts-store-git-8844fb-bigcommerce-platform.vercel.app) | | Aug 29, 2024 10:29pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/D3W2WAkaNmhY1TLEqX4GYsPdq8ox)) | [Visit Preview](https://catalyst-au-git-deini-i18n-bigcommerce-platform.vercel.app) | | Aug 29, 2024 10:29pm | | **catalyst-staging** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-staging/5mScqgVN5jLtsSSULgMNDEtUydkw)) | [Visit Preview](https://catalyst-staging-git-deini-i18n-bigcommerce-platform.vercel.app) | | Aug 29, 2024 10:29pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/4LQpk8mhXSe5LX3hzQn1WvRQFkxv)) | [Visit Preview](https://catalyst-test-store-git-deini-i18n-bigcommerce-platform.vercel.app) | | Aug 29, 2024 10:29pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/8wnSo3up6Dk6TGdkLnSK3tz6QqBS)) | [Visit Preview](https://catalyst-uk-git-deini-i18n-bigcommerce-platform.vercel.app) | | Aug 29, 2024 10:29pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/BdpnfBnhGw96ruaGEvNf7oEqt9m2)) | [Visit Preview](https://catalyst-unstable-git-deini-i18n-bigcommerce-platform.vercel.app) | | Aug 29, 2024 10:29pm |
changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 547dda78d40aad9dfd8bc63152af3d3c6d51b036

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 2 months ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-fi7mrrql6-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 84
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 89
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85