search

bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
93 stars 65 forks source link

fix: remove pagination cursors from search params on sort change #1328

Closed willPrattUPL closed 1 week ago

willPrattUPL commented 2 weeks ago

What/Why?

removes pagination cursors from search params when changing sort option

old cursors were sticking around in the url after changing sort which messed up pagination.

Testing

  1. find a search with enough results for pagination
  2. click through a few pages
  3. change the sort option
  4. it should reload on first page result of new sort selection & remove the cursors from params

Extends from slack conversation in bigcommercedevs/#catalyst

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: f12a8d85b141ac4c1046df1585dc0a1f3b162866

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 2 weeks ago

@willPrattUPL is attempting to deploy a commit to the BigCommerce Platform Team on Vercel.

A member of the Team first needs to authorize it.