bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
93 stars 65 forks source link

fix(core): update multiline field to respect required settings #1329

Closed bc-alexsaiannyi closed 1 week ago

bc-alexsaiannyi commented 2 weeks ago

What/Why?

This PR fixes an issue that multiline form field doesn't respect required settings from Control Panel.

Testing

locally

https://github.com/user-attachments/assets/e71be772-2398-43a8-814b-15343e92bc01

https://github.com/user-attachments/assets/6f09b4a0-b672-4ec1-a326-5bb2f1e520c6

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 01a417ec7f6a5b1296d760ec39c0f9abcfb44b50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------- | ----- | | @bigcommerce/catalyst-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 2:55pm
7 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst/9FWrdKwFmLi3DPNwbeCEuoAbioyK)) | | | Sep 6, 2024 2:55pm | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/6pE3yx4NyUcN9Q8XRsboxqSJxWLh)) | [Visit Preview](https://catalyst-1millionproducts-store-git-da9111-bigcommerce-platform.vercel.app) | | Sep 6, 2024 2:55pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/gFRAFmHGNAYv6gQ1ctuSSV9zSswB)) | [Visit Preview](https://catalyst-au-git-fix-multiline-form-field-bigcommerce-platform.vercel.app) | | Sep 6, 2024 2:55pm | | **catalyst-staging** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-staging/4Lf2yTHaVA2HybCypJzJL5GehSiB)) | [Visit Preview](https://catalyst-staging-git-fix-multiline-f216d1-bigcommerce-platform.vercel.app) | | Sep 6, 2024 2:55pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/HJV57aEdAnmarDcnY9WC4DCdoAAz)) | [Visit Preview](https://catalyst-test-store-git-fix-multili-a54b7f-bigcommerce-platform.vercel.app) | | Sep 6, 2024 2:55pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/69LeGWzeziKdvsxBbsBmw2VfP5Tr)) | [Visit Preview](https://catalyst-uk-git-fix-multiline-form-field-bigcommerce-platform.vercel.app) | | Sep 6, 2024 2:55pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/4qBnd7HNb6DndS8mBf5QFBCeQQUo)) | [Visit Preview](https://catalyst-unstable-git-fix-multiline-dcb0a2-bigcommerce-platform.vercel.app) | | Sep 6, 2024 2:55pm |
github-actions[bot] commented 1 week ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-iwodfc1n7-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 93
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 88
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85