bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
93 stars 65 forks source link

fix(core): update localeSwitcher to use link instead of form #1342

Closed jorgemoya closed 1 week ago

jorgemoya commented 1 week ago

What/Why?

Use link instead of form. Simplifies logic and behaves better.

Testing

Locally, it redirects to correct locale without use, even when always showing locale prefix.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 9:11pm
7 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst/DFRc76yPrDtHG5RkXopo7ocPbaCQ)) | | | Sep 5, 2024 9:11pm | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/2Gw9KPgJy3vkPm1sw73PYANx2Mcu)) | [Visit Preview](https://catalyst-1millionproducts-store-git-89f6a3-bigcommerce-platform.vercel.app) | | Sep 5, 2024 9:11pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/kwma4o2pPqykMdv9xNJajMqHgUKs)) | [Visit Preview](https://catalyst-au-git-fix-locale-switcher-bigcommerce-platform.vercel.app) | | Sep 5, 2024 9:11pm | | **catalyst-staging** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-staging/9ZfEGGDmi6TuX9CfDxpg8wWbpPXF)) | [Visit Preview](https://catalyst-staging-git-fix-locale-switcher-bigcommerce-platform.vercel.app) | | Sep 5, 2024 9:11pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/7nGKexfFitDtGs9A5wffqgMbcQF1)) | [Visit Preview](https://catalyst-test-store-git-fix-locale-f67721-bigcommerce-platform.vercel.app) | | Sep 5, 2024 9:11pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/6qDXsKHAtkCbEjtkjBKbE6f9QqMr)) | [Visit Preview](https://catalyst-uk-git-fix-locale-switcher-bigcommerce-platform.vercel.app) | | Sep 5, 2024 9:11pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/BQ4WFQv3Rd8VVnmCyHCSxQP33tjA)) | [Visit Preview](https://catalyst-unstable-git-fix-locale-switcher-bigcommerce-platform.vercel.app) | | Sep 5, 2024 9:11pm |
changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: 0fee6febca678af1e0398bbb083b7f8c71645fdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------- | ----- | | @bigcommerce/catalyst-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 week ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-ljgdhkrrg-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 84
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85