bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
93 stars 65 forks source link

fix(core): fix placeholder positioning for picklist custom form field #1346

Closed bc-alexsaiannyi closed 1 week ago

bc-alexsaiannyi commented 1 week ago

What/Why?

This PR fixes issue with 'floating' placeholder positioning for Picklist form field.

Testing

locally

https://github.com/user-attachments/assets/3f51f7a4-6f47-4613-ad58-85b812a0ef2f

https://github.com/user-attachments/assets/39c563b6-2fc0-4faf-9f65-6d551a17bf1c

changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: b8945a7d5dd417901610b57b0d1a24563aefabaf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------- | ----- | | @bigcommerce/catalyst-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 3:06pm
7 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst/6SH96nbmDPhDsuqfCby3s8BQneVF)) | | | Sep 6, 2024 3:06pm | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/2iKGZxjWjt8sZ11EzAGX4zRbGvAU)) | [Visit Preview](https://catalyst-1millionproducts-store-git-ef7eba-bigcommerce-platform.vercel.app) | | Sep 6, 2024 3:06pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/7HiNTUXXQt9HeK7oHMheuSqidf7N)) | [Visit Preview](https://catalyst-au-git-fix-picklist-form-field-bigcommerce-platform.vercel.app) | | Sep 6, 2024 3:06pm | | **catalyst-staging** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-staging/9fzUguiFVsASxUXs9W7godZ7ppzW)) | [Visit Preview](https://catalyst-staging-git-fix-picklist-f-9cc59a-bigcommerce-platform.vercel.app) | | Sep 6, 2024 3:06pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/PML8DGRr4L8b75RCUC4LcYfhJqkM)) | [Visit Preview](https://catalyst-test-store-git-fix-picklis-d91afc-bigcommerce-platform.vercel.app) | | Sep 6, 2024 3:06pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/DR8kUqVjSNBkiHGYXA8Vk7jXoRXn)) | [Visit Preview](https://catalyst-uk-git-fix-picklist-form-field-bigcommerce-platform.vercel.app) | | Sep 6, 2024 3:06pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/4hwTGMM5zTYJTh5jix8ATV31LQwS)) | [Visit Preview](https://catalyst-unstable-git-fix-picklist-bfca1b-bigcommerce-platform.vercel.app) | | Sep 6, 2024 3:06pm |
github-actions[bot] commented 1 week ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-p91u29qqx-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 84
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 97
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85