bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
93 stars 65 forks source link

fix(core): incorrect template string for da and fr messages #1358

Closed jorgemoya closed 6 days ago

jorgemoya commented 6 days ago

What/Why?

Was causing an error when using these strings. Not sure if it was incorrectly added originally, or if the bot messed it up.

Testing

Locally, it works now.

vercel[bot] commented 6 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 8:05pm
6 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst/4RmDbttDhneJuGie6schYQCMuCzU)) | | | Sep 11, 2024 8:05pm | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/pDj2jxXGB5AMp1i2kZtXm9ioPero)) | | | Sep 11, 2024 8:05pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/6D3HgLKqac3YKjQ9vgkfiBSbgsY3)) | | | Sep 11, 2024 8:05pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/4yPTzZJAA77CdidQnJ9oFK4pS6Um)) | | | Sep 11, 2024 8:05pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/8KqN8jXMHv3h25Hw8Q2SFLgK6QSn)) | | | Sep 11, 2024 8:05pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/4RK64i8utuQyaVXyJ955oY6zmxro)) | | | Sep 11, 2024 8:05pm |
changeset-bot[bot] commented 6 days ago

🦋 Changeset detected

Latest commit: 7a6dd18e30b31523eff6832a70876700571cfa06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------- | ----- | | @bigcommerce/catalyst-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 6 days ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-626i0bhy7-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 83
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 94
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85