bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
110 stars 119 forks source link

fix(core): manually pass in channel id for get favicon query #1369

Closed jorgemoya closed 1 month ago

jorgemoya commented 1 month ago

What/Why?

Pass in default channel to favicon query, since getLocale can't be used in routes.

Testing

Locally, I no longer see the console error.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 8:28pm
catalyst-latest 🛑 Canceled (Inspect) 💬 Add feedback Sep 13, 2024 8:28pm
5 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/6jct6a8zTSCmaqPAFbrb3rRWeRBZ)) | [Visit Preview](https://catalyst-1millionproducts-store-git-c769a4-bigcommerce-platform.vercel.app) | | Sep 13, 2024 8:28pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/DNtL5crkbKa5tq541bxbBid9vUi6)) | [Visit Preview](https://catalyst-au-git-fix-warning-favicon-bigcommerce-platform.vercel.app) | | Sep 13, 2024 8:28pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/27ASm98NqFrrDF3tSK7CQRZ9qGWX)) | [Visit Preview](https://catalyst-test-store-git-fix-warning-d2eb15-bigcommerce-platform.vercel.app) | | Sep 13, 2024 8:28pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/GDMT8atKKDsB6phYqmQJpAUx3pAT)) | [Visit Preview](https://catalyst-uk-git-fix-warning-favicon-bigcommerce-platform.vercel.app) | | Sep 13, 2024 8:28pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/8oU8SQ9yVCtW4LjijAwA7STQ4g7c)) | [Visit Preview](https://catalyst-unstable-git-fix-warning-favicon-bigcommerce-platform.vercel.app) | | Sep 13, 2024 8:28pm |
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: f78cc925f1f2a04b63dc831b1df5a58d6e516238

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------- | ----- | | @bigcommerce/catalyst-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-bka0aqpgo-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 95
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85