bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
99 stars 95 forks source link

create-catalyst @0.13.0 failing to start in Windows 10 - GIT not found error #1463

Closed druellan closed 23 minutes ago

druellan commented 3 hours ago

Describe the bug When trying to create a new Catalyst site with create-catalyst@0.13.0, I get an error message about GIT not being installed, and the process stops.

To Reproduce Steps to reproduce the behavior:

  1. run "npm create @bigcommerce/catalyst@0.13.0"
  2. answer "Y" to "Need to install the following packages: @bigcommerce/create-catalyst@0.13.0 Ok to proceed? (y) y"

Console `npm create @bigcommerce/catalyst@0.13.0 Need to install the following packages: @bigcommerce/create-catalyst@0.13.0 Ok to proceed? (y) y

◢ @bigcommerce/create-catalyst v0.13.0

Error: git is required to create a Catalyst project

npm ERR! code 1 npm ERR! path D:\Documents\LO-Tape-Catalyst npm ERR! command failed npm ERR! command C:\Windows\system32\cmd.exe /d /s /c create-catalyst

npm ERR! A complete log of this run can be found in: C:\Users\Psy\AppData\Local\npm-cache_logs\2024-10-15T12_47_35_644Z-debug-0.log`

Log

2024-10-15T12_47_35_644Z-debug-0.log

Additional context Windows 10 I'm using NVM and NODE version v20.9.0 GIT is installed and available in the path. Works with create-catalyst@0.12.0

chanceaclark commented 2 hours ago

@druellan Thanks for reporting this!

@matthewvolk this might because which is not a command on Windows :( https://github.com/bigcommerce/catalyst/commit/673bea2bef3d7b80267c7f0c8b204b652fd09f34#diff-d6d218ba01140fd6bebf1cf5f8325f993e96717aa24b7d12166fff34cae34e6bR70 Might have to go with your alternate method that you had initially.

druellan commented 23 minutes ago

Thanks! I'll try patching that locally and see if that solves the issue.