Closed jorgemoya closed 1 month ago
Latest commit: ecff89e8e62f63d9de51dc9c96d86e1683108ed2
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
catalyst | 🔄 Building (Inspect) | Visit Preview | 💬 Add feedback | Oct 21, 2024 6:01pm |
catalyst-latest | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 21, 2024 6:01pm |
Reported this issue from working on this: https://github.com/amannn/next-intl/issues/1438
I had to pass default locale for these redirect in routes since next-intl does not work here.
Lighthouse ran against https://catalyst-latest-3y8sa2rdi-bigcommerce-platform.vercel.app
We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
Category | Score |
---|---|
🟠 Performance | 81 |
🟢 Accessibility | 100 |
🟢 Best practices | 100 |
🟠 SEO | 82 |
We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
Category | Score |
---|---|
🟢 Performance | 99 |
🟢 Accessibility | 100 |
🟢 Best practices | 100 |
🟠 SEO | 85 |
What/Why?
next-intl
.createNavigation
api.locale
toredirects
.setRequestLocale
is no longer unstable.Testing
Locally, redirecting on default locale will not append the default locale, just like Links. Updated tests to match this behavior.