bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
120 stars 162 forks source link

chore(core): bump next-intl #1491

Closed jorgemoya closed 1 month ago

jorgemoya commented 1 month ago

What/Why?

Testing

Locally, redirecting on default locale will not append the default locale, just like Links. Updated tests to match this behavior.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: ecff89e8e62f63d9de51dc9c96d86e1683108ed2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------- | ----- | | @bigcommerce/catalyst-core | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 6:01pm
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 6:01pm
5 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/CS2BKs7Y9zd5j5oZYBxb9THTK8tW)) | [Visit Preview](https://catalyst-1millionproducts-store-git-721ce5-bigcommerce-platform.vercel.app) | | Oct 21, 2024 6:01pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/9Swkj1k3t9ugJRSnEPcu6Jj7NNJE)) | [Visit Preview](https://catalyst-au-git-bump-next-intl-bigcommerce-platform.vercel.app) | | Oct 21, 2024 6:01pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/G4eMjRBGF3P44mHWTY3MRYGBzwqU)) | [Visit Preview](https://catalyst-test-store-git-bump-next-intl-bigcommerce-platform.vercel.app) | | Oct 21, 2024 6:01pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/8sKkkQgBD5jNgJmGzCcj5uj9ad8W)) | [Visit Preview](https://catalyst-uk-git-bump-next-intl-bigcommerce-platform.vercel.app) | | Oct 21, 2024 6:01pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/GQC6s5xUbGK6jbBtgoBpGtXG6zAa)) | [Visit Preview](https://catalyst-unstable-git-bump-next-intl-bigcommerce-platform.vercel.app) | | Oct 21, 2024 6:01pm |
jorgemoya commented 1 month ago

Reported this issue from working on this: https://github.com/amannn/next-intl/issues/1438

jorgemoya commented 1 month ago

I had to pass default locale for these redirect in routes since next-intl does not work here.

github-actions[bot] commented 1 month ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-3y8sa2rdi-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 81
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 85