bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
120 stars 161 forks source link

fix(core): improve error message on reset password page #1520

Closed bc-alexsaiannyi closed 1 month ago

bc-alexsaiannyi commented 1 month ago

What/Why?

This PR improves validation error on Reset Password form for User. Previously Zod Error was an array of data that was quite hard to read through so we've transformed it into a message where User can read about invalid field and reason for appeared error.

Testing

locally

error_message

https://github.com/user-attachments/assets/d25bc125-a6cf-4aeb-9aee-7537c0bf521c

https://github.com/user-attachments/assets/908c6ded-b637-4125-a782-fdd1b5fa43e8

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 009fc8b2fa4b7a02ffaff40eb33ed5ae62fc034b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------- | ----- | | @bigcommerce/catalyst-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 8:53am
6 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst/9eu6Yz3ZYMEMRcCKYEY3ZT43ZYTA)) | | | Nov 4, 2024 8:53am | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/7n3VHSggUZXsJbngYYsss8ctbY9V)) | [Visit Preview](https://catalyst-1millionproducts-store-git-4715f1-bigcommerce-platform.vercel.app) | | Nov 4, 2024 8:53am | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/A12QEkRWAFtYWicN1xerdLQdT12v)) | [Visit Preview](https://catalyst-au-git-fix-reset-password-e2bc02-bigcommerce-platform.vercel.app) | | Nov 4, 2024 8:53am | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/GYFRtHGtLotpkWX8DgqAmHupBdkW)) | [Visit Preview](https://catalyst-test-store-git-fix-reset-p-5632b9-bigcommerce-platform.vercel.app) | | Nov 4, 2024 8:53am | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/ExD1kSgTD5mpVZUrv4coZowJCBNk)) | [Visit Preview](https://catalyst-uk-git-fix-reset-password-1d3097-bigcommerce-platform.vercel.app) | | Nov 4, 2024 8:53am | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/GKHwXwZqdqqWAa7mXvmh1aiyczx4)) | [Visit Preview](https://catalyst-unstable-git-fix-reset-pas-65cee5-bigcommerce-platform.vercel.app) | | Nov 4, 2024 8:53am |
github-actions[bot] commented 1 month ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-c8bskcewf-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 79
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 95
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85