search

bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
118 stars 161 forks source link

fix: add z-index to select to prevent it from being hidden #1584

Closed jorgemoya closed 3 weeks ago

jorgemoya commented 3 weeks ago

What/Why?

Sets a z-index to prevent select from being hidden by other elements.

Before:

https://github.com/user-attachments/assets/b1db962f-b8b9-455c-9123-3bec2100839c

After:

https://github.com/user-attachments/assets/ca1177e3-4eec-4b43-8c16-acbab613d1b3

Testing

Locally.

changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: a2c45c9053a4247e7ee88b3f43716a0724ecd333

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 1:06pm
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 1:06pm
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 1:06pm
4 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/FZPnu8gMwqxcKpKbjgXqHSzNy116)) | [Visit Preview](https://catalyst-1millionproducts-store-git-fd418f-bigcommerce-platform.vercel.app) | | Nov 9, 2024 1:06pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/8jTvEz6U89Fp6CgDNwhR4sBMWnuY)) | [Visit Preview](https://catalyst-au-git-vibes-soul-with-mak-e1f255-bigcommerce-platform.vercel.app) | | Nov 9, 2024 1:06pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/J9ca7otSWcuyXstxAPTVcpKPBtj9)) | [Visit Preview](https://catalyst-uk-git-vibes-soul-with-mak-170144-bigcommerce-platform.vercel.app) | | Nov 9, 2024 1:06pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/5Xu1XW3zAyzMiRi5SdFAS6uvTstm)) | [Visit Preview](https://catalyst-unstable-git-vibes-soul-wi-9ad626-bigcommerce-platform.vercel.app) | | Nov 9, 2024 1:06pm |
jorgemoya commented 3 weeks ago

We generally try to above z-index or only use them in stacking contexts where the z-indexes are in the same file. What particular component was this one fighting with?

Generally yes I agree, I think Select is one of two cases were we need it to overlap whatever is being rendered behind. In this case, it clashes with the Navigation component.