search

bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
118 stars 161 forks source link

fix: cursor navigation by removing unused param #1589

Closed jorgemoya closed 3 weeks ago

jorgemoya commented 3 weeks ago

What/Why?

For cursor navigation we either want an after or before, not both.

Before:

https://github.com/user-attachments/assets/e7189cd1-ebbf-47df-8197-211073c94ed5

After:

https://github.com/user-attachments/assets/1a76128f-846a-418e-913d-368e724c8254

Testing

Locally.

changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: d0b64e3bed0b6a9cd32ad47024fe15effb1ed7f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 1:50am
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 1:50am
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 1:50am
4 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/DcaW9UkkxbfYHP2epja2Fmg6CdSE)) | [Visit Preview](https://catalyst-1millionproducts-store-git-fc266b-bigcommerce-platform.vercel.app) | | Nov 9, 2024 1:50am | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/J3sZHeT555Ek5uGmWYBNAPceYfoy)) | [Visit Preview](https://catalyst-au-git-vibes-soul-with-mak-22bb91-bigcommerce-platform.vercel.app) | | Nov 9, 2024 1:50am | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/FwhkvUUV2EQdzG7g5mAgG8u5TgMH)) | [Visit Preview](https://catalyst-uk-git-vibes-soul-with-mak-83bc00-bigcommerce-platform.vercel.app) | | Nov 9, 2024 1:50am | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/6t1QEbjQbKakSheLoXUC1jYViL64)) | [Visit Preview](https://catalyst-unstable-git-vibes-soul-wi-ff2be4-bigcommerce-platform.vercel.app) | | Nov 9, 2024 1:50am |