bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
117 stars 153 forks source link

fix(core): refresh the entire list of addresses after deleting an address #1651

Open bc-yevhenii-buliuk opened 2 weeks ago

bc-yevhenii-buliuk commented 2 weeks ago

What/Why?

This PR fixes the display of the existing address list after removing all visible addresses on the page. Also this PR updates the entire list of addresses after deleting an address.

Testing

locally

before:

https://github.com/user-attachments/assets/bdc81450-2b76-47a5-9ea9-ff202c2d4e43

after:

https://github.com/user-attachments/assets/d1e82a99-2a31-45a3-9ef7-505ae03dd2e7

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 5:40pm
5 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst/FW61adsFT5DJrybK3jWJWLccEyhd)) | | | Nov 21, 2024 5:40pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/JBm7Zxm8KLhySPjYeXR7zauw3cnD)) | [Visit Preview](https://catalyst-au-git-fix-address-list-pa-eac560-bigcommerce-platform.vercel.app) | | Nov 21, 2024 5:40pm | | **catalyst-soul** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-soul/5Ym5FhToZpsBG5gif3hj2eYggtMH)) | [Visit Preview](https://catalyst-soul-git-fix-address-list-9f1b71-bigcommerce-platform.vercel.app) | | Nov 21, 2024 5:40pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/CaWK1QL4cAiNyryBt1RAB6uy4hQX)) | [Visit Preview](https://catalyst-uk-git-fix-address-list-pa-682a43-bigcommerce-platform.vercel.app) | | Nov 21, 2024 5:40pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/6ex9hJ8aUXcaEUmmUnEr1v9jwT6D)) | [Visit Preview](https://catalyst-unstable-git-fix-address-l-cf9b93-bigcommerce-platform.vercel.app) | | Nov 21, 2024 5:40pm |
changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 51c1585a0d7cc6418a34a86ab25d2c813f1d8c31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------- | ----- | | @bigcommerce/catalyst-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

bc-alexsaiannyi commented 1 week ago

just don't forget to fix lint errors

github-actions[bot] commented 1 week ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-g21ngivm6-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 83
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 90
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85