matthewvolk commented 1 week ago

What/Why?

Some users get the following error when trying to run pnpm run lint:

/Users/user.name/catalyst/packages/client/dist/index.js:153
      throw new Error("Client configuration must include a channelId.");
            ^

Error: Client configuration must include a channelId.
    at new Client (/Users/user.name/catalyst/packages/client/dist/index.js:153:13)
    ...

This PR adds env awareness to tasks run from root which should fix the issue

Testing

Locally

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: 4a085820bf8534ced3aea719603a6375b2b86c9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
catalyst-latest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 18, 2024 8:50pm

5 Skipped Deployments

github-actions[bot] commented 1 week ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-4hazq151u-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category	Score
🟠 Performance	80
🟢 Accessibility	96
🟢 Best practices	100
🟠 SEO	82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category	Score
🟢 Performance	92
🟢 Accessibility	96
🟢 Best practices	100
🟠 SEO	85

bigcommerce / catalyst

fix: run root lint task with env #1654