Fix command check for Windows in create

bigcommerce / catalyst

Catalyst - for Composable Commerce

https://catalyst-demo.site

MIT License

117 stars 153 forks source link

Fix command check for Windows in create #1683

Open benbhall opened 1 week ago

benbhall commented 1 week ago

Closes #1463

What/Why?

Fix the create CLI command to improve cross-platform compatibility when checking for required tools (git and pnpm). Currently it does not work on Windows.

Introduced a utility function getPlatformCheckCommand
Using where.exe (instead of where) for Windows to avoid conflicts with PowerShell's Where-Object.
Fall back to existing which for Unix systems.

Testing

Simulated missing tools to confirm that error messages display as expected.
Windows: Tested in Command Prompt and PowerShell, with and without git/pnpm available.

No specific regression testing done over Linux/MacOS behaviour.

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: c8508e69cf072aaceb568f475d4300ce388ae87e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 week ago

Someone is attempting to deploy a commit to the BigCommerce Platform Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment