bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
117 stars 153 forks source link

FIX missing aria labels on compare #1688

Closed thebigrick closed 3 days ago

thebigrick commented 6 days ago

What/Why?

Lighthouse was reporting 93 on Accessibility on PLP. Just added an aria-label to compare to have 100%

Testing

Open a PLP, run Lighthouse, and check the accessibility score.

changeset-bot[bot] commented 6 days ago

🦋 Changeset detected

Latest commit: 0db52abd6930ee5f245e8922bd735e7af8c65d35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------- | ----- | | @bigcommerce/catalyst-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 6 days ago

@thebigrick is attempting to deploy a commit to the BigCommerce Platform Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 3 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview Nov 29, 2024 3:43pm
github-actions[bot] commented 2 days ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-9169kxuu8-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 90
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 87
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85