search

bigcommerce / checkout-sdk-js

BigCommerce Checkout JavaScript SDK
MIT License
132 stars 215 forks source link

Revert "Revert "feat(shipping): SHIPPING-3183 Add support for channel_ids to the load shipping countries action"" #2617

Closed agchan12 closed 2 weeks ago

agchan12 commented 3 weeks ago

What?

This is a revert of the revert. i.e. we are re-raising this PR

This adds support for displaying available shipping countries based on shipping method channel associations.

Why?

To support this we need checkout to query the shipping/countries endpoint with a channel_id through as a query parameter.

Testing/Proof

With the checkout-sdk-js and checkout-js running locally, the channel_id is piped through from checkout-sdk to checkout. The following video shows that the shipping/countries endpoint now has the query parameter channel_id passed through to it.

https://github.com/user-attachments/assets/39db2078-e888-4479-95fd-15107d74f6e2

ping @bigcommerce/team-checkout

theromulans commented 3 weeks ago

Was the original revert not needed?

agchan12 commented 3 weeks ago

@theromulans

For context we need to manually release checkout-sdk-js -> Bump checkout-js -> Bump BCApp

I released checkout-sdk-js and was attempting to release it in checkout-js, however I ran into some e2e test failures when I attempted to bump the version in checkout-js. This was holding up the pipeline for other people in checkout-sdk-js. So the revert is just to unblock the pipeline whilst I sort out the failing test issues in checkout-js.

This PR is still needed, but I still have to prepare the rest of pipeline to ensure that the bumps go smoothly despite the core changes being here.