search

bigcommerce / cornerstone

The BigCommerce Cornerstone theme
https://developer.bigcommerce.com/stencil-docs
287 stars 606 forks source link

Update to Foundation 6 #1506

Open ikoruk opened 5 years ago

ikoruk commented 5 years ago

Any chance to update to Foundation 6 which would provide more modern components and reduce the size of the CSS? It is already over 4 years old...

c-s-alex commented 5 years ago

100% agree

ghost commented 5 years ago

@ikoruk Thank you for opening this issue. We will look into that and comment on this issue with an update

fthobe commented 5 years ago

up

PeteyRev commented 4 years ago

@ikoru @bc-zoharmuzafi It seems as if you are looking to take the time to update Foundation, I would highly recommend removing foundation and opting for a more modular, simple solution such as Bulma. Cornerstone doesn't seem to need the tools that Foundation can bring to the table, it just needs a simple layout and styling system that is easy to customize

IslandUsurper commented 4 years ago

The fate of Foundation has been unclear for a while: foundation/foundation-sites#11767. While it seems like development is picking back up, migrating to a different framework may be a good option.

Cornerstone doesn't seem to need the tools that Foundation can bring to the table

I'd argue that it's not just Cornerstone that uses Foundation, but all of the themes that are built on top of it too. The majority of theme developers are going to reach for what already exists in the theme and use it to suit their needs, rather than rip it out and put something else in. Whatever Cornerstone uses needs to be powerful and flexible enough that people don't need to get something else to do what they want.

ikoruk commented 4 years ago

Foundation Sites 6.6.0 was just released. While it would be nice to have a more simple solution, it might be less work to simply update to the latest foundation. But the more this also is delayed, the more technical debt builds up for all the themes built on top of Cornerstone as well.

amfischer commented 1 year ago

It would be nice if the Foundation dependency was updated to version 6. As others have mentioned it's been out for some time now.

I found this issue because I was trying to add an event listener for the Tabs component and I was getting stuck. I realized the event names in version 6 are different than version 5, and it's actually not easy to navigate Foundation 5 documentation (many of the links don't work). I had to dig into the source code to find the fired event names for Tabs.