search

bigcommerce / gruf-rspec

RSpec helper suite for gruf
MIT License
23 stars 6 forks source link

Controller Matcher Configuration #10

Closed eiei0 closed 3 years ago

eiei0 commented 3 years ago

Summary

According to the README, the developer should be able to overwrite the default path with the RPC_SPEC_PATH environment variable. Currently this is not respected when loading the configuration.

To resolve the problem, this change mainly just relocates the code that fetches the environment variable from the VALID_CONFIG_KEYS default config constant, to the .options method. There it gives priority to the variable, then if the configuration is set, and then the default value that is set when .reset is initially called.

Closes #7

eiei0 commented 3 years ago

@splittingred when you get a moment, could you take a peek a this?

splittingred commented 3 years ago

@eiei0 I've cut 0.3.0 (the minor bump is due to dropping Ruby < 2.6 support). I'd give Rubygems about 15m to propagate its cache, and then you should be good to go. Feel free to close this whenever you confirm it addresses your issue. Thanks!