bigcommerce / gruf-rspec

RSpec helper suite for gruf
MIT License
23 stars 6 forks source link

Remove unnecessary dependencies and support for older versions #23

Closed ydah closed 4 months ago

ydah commented 4 months ago

What? Why?

I noticed that adding gruf-rspec to a Gemfile adds gems other than the rspec-core and rspec-expectations. Dependencies on only rspec-core and rspec-expectations are fine because they use only the following APIs:

We also care for an older version, which I think is care up to rspec 1.3.2. This project relies on RSpec 3.8+, which I think is unnecessary. https://www.rubydoc.info/gems/rspec/1.3.2/Spec/Runner