search

bigcommerce / gruf-rspec

RSpec helper suite for gruf
MIT License
23 stars 6 forks source link

Update to rubocop 1.0, deprecate Ruby < 2.6, add 2.7 tests #9

Closed splittingred closed 4 years ago

splittingred commented 4 years ago

What?

@bigcommerce/ruby @bigcommerce/platform-engineering @bigcommerce/oss-maintainers

fteem commented 3 years ago

@splittingred my apologies for digging out this PR, but I was wondering why the deprecation of Ruby <2.6 here?

The required Ruby version for gruf itself is currently >= 2.4, < 3.1, effectively meaning that folks that use gruf on Ruby < 2.6 cannot use gruf-rspec.

Thanks in advance for all your hard work on gruf and for taking the time to reply! 🙏

splittingred commented 3 years ago

Hi @fteem - we made a decision to not support Ruby 2.4, as it has been fully EOLed: https://www.ruby-lang.org/en/downloads/branches/ 2.5 will EOL this month, so this was pre-emptive in moving that direction.

Given the security risks in running an EOL version of Ruby, we decided to align gruf/gruf-rspec with the broader Ruby community. The Gruf gem in particular plans to do so in a 2.10 release coming soon.

Apologies for any inconvenience this causes, but I would strongly recommend upgrading to 2.6+ in your systems, due to the security risks in running an EOL version. Gruf also uses other gems under the hood, and cannot guarantee those will not implement a 2.6+ requirement as well.

For <2.6 versions, you can still use older versions of gruf-rspec that do not have the 2.6+ requirement, but for future gruf-rspec functionality, we will be requiring 2.6+.

fteem commented 3 years ago

@splittingred thanks for the context and the advice, much appreciated! Thanks again for all your work here! 🙏