bigcommerce / gruf

gRPC Ruby Framework
https://github.com/bigcommerce/gruf
MIT License
626 stars 73 forks source link

2.16 appears to autoload the HealthCheck even if not enabled #168

Closed tmtrademarked closed 2 years ago

tmtrademarked commented 2 years ago

Please describe the issue

From what I can tell, it appears that Gruf 2.16 autoloads the health check as a service even if not requested if eager_load is true in the environment. This seems slightly undesirable since it might conflict with an existing health check RPC definition.

How to Reproduce

Steps to reproduce the behavior:

What should happen?

It probably shouldn't load this unless requested - it's documented as opt in, after all. This created a problem for us because we had our own implementation of this check that was colliding with Gruf's when we went to implement it.

Anything else we should know?

gRPC 1.48.0, Ruby 2.7 and 3.0 environments

splittingred commented 2 years ago

This has been fixed in https://github.com/bigcommerce/gruf/releases/tag/v2.16.1 - thanks for the report!