bigcommerce / gruf

gRPC Ruby Framework
https://github.com/bigcommerce/gruf
MIT License
626 stars 73 forks source link

Introduce read-write lock for code reloading; do code reloading before controller name resolution #178

Closed leonid-shevtsov closed 1 year ago

leonid-shevtsov commented 1 year ago

What? Why?

How was it tested?

leonid-shevtsov commented 1 year ago

Not sure what i should do with the rubocop & codeclimate errors; i could refactor ServiceBinder, but it seems like the issue has been there before my changes. Rubocop issues are old as well.

leonid-shevtsov commented 1 year ago

Updated to bypass locking mechanism

splittingred commented 1 year ago

@leonid-shevtsov Thanks! https://github.com/bigcommerce/gruf/pull/181 should fix the rubocop issue. (Edit: this has been merged now, can you rebase?) - Also, can you update CHANGELOG.md with a description of the changes?

leonid-shevtsov commented 1 year ago

Sorry, got back from the break. All done. Pleased to resolve my own rubocop warnings.