Closed leonid-shevtsov closed 1 year ago
Not sure what i should do with the rubocop & codeclimate errors; i could refactor ServiceBinder, but it seems like the issue has been there before my changes. Rubocop issues are old as well.
Updated to bypass locking mechanism
@leonid-shevtsov Thanks! https://github.com/bigcommerce/gruf/pull/181 should fix the rubocop issue. (Edit: this has been merged now, can you rebase?) - Also, can you update CHANGELOG.md
with a description of the changes?
Sorry, got back from the break. All done. Pleased to resolve my own rubocop warnings.
What? Why?
How was it tested?