search

bigcommerce / paper-handlebars

Paper plugin for rendering via Handlebars.js
BSD 4-Clause "Original" or "Old" License
12 stars 36 forks source link

fix(storefront): STRF-11941 Remove quotes from nonce #309

Closed huntario closed 4 months ago

huntario commented 5 months ago

What? Why?

Remove the quotes from nonce helper.

Collaboration with Merchandising on nonce.

How was it tested?

Run storefront-renderer-2 locally with local paper and paper handlebars via npm link

  1. cd into local paper and paper handlebars directories npm link
  2. Then in storefront-renderer-2 npm link @bigcommerce/stencil-paper npm link @bigcommerce/stencil-paper-handlebars
  3. dev.yml 
    storefront-renderer-2:
rpc:
  port: 9998

Screenshot 2024-06-05 at 7 46 24 PM

cc @bigcommerce/storefront-team cc @jkanive @bc-erich

jkanive commented 5 months ago

@huntario In your screenshot it shows that it has " inside the string. Are we not performing a base64 conversion of the nonce?

huntario commented 5 months ago

Talked in Slack about this and the base64 aspect will need to be handled in Storefront - https://github.com/bigcommerce/storefront/blob/e9714a4ba6c2b0e6e377dce47b959d7c15dded9e/src/main/scala/com/bigcommerce/storefront/routers/StorefrontTemplateRouter.scala#L161 - in a separate PR.

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 5.10.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: