bigcommerce / stencil-cli

BigCommerce Stencil emulator for local theme development
https://developer.bigcommerce.com/stencil-docs
BSD 4-Clause "Original" or "Old" License
102 stars 142 forks source link

fix(storefront): MERC-9452 Return variation id when activating theme #1094

Closed bc-jcha closed 1 year ago

bc-jcha commented 1 year ago

What?

Currently Kibana and CP staff logs are logging variation ID when a theme is applied. Return a variation ID when activating a theme using Stencil CLI so that a developer can match the log with the corresponding variation ID.

Tickets / Documentation

https://bigcommercecloud.atlassian.net/browse/MERC-9452

Screenshots (if appropriate)

Screen Shot 2023-04-21 at 1 26 16 PM

cc @bigcommerce/storefront-team

jairo-bc commented 1 year ago

Hi @bc-jcha,

Currently chore is not a valid commit type, but CI still passes. Do you mind changing it to fix, so we could publish can bump the version through CI?

bc-jcha commented 1 year ago

LGTM, just PR title needs to be changed

Done, thank you! Approval would be appreciated @jairo-bc

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 7.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: