bigcommerce / stencil-cli

BigCommerce Stencil emulator for local theme development
https://developer.bigcommerce.com/stencil-docs
BSD 4-Clause "Original" or "Old" License
102 stars 140 forks source link

Making `SASS_ENGINE_NAME` configurable #1109

Closed Dru-S closed 1 year ago

Dru-S commented 1 year ago

Expected behavior

Constant SASS_ENGINE_NAME used in lib/css/compile.js configurable from an environment variable, config.json entry, or similar, in order to possibly change the default SASS/Scss compiler from node-sass, to dart-sass (since also node-sass is deprecated)

Actual behavior

Constant SASS_ENGINE_NAME is static, and assigned to node-sass.

Steps to reproduce behavior

Environment

Stencil-cli version stencil --version: 7.1.2

Node version node -v: v18.14.2

NPM version npm -v: 9.5.0

OS: macOS Ventura

jairo-bc commented 1 year ago

Hi @Dru-S, currently we don't support dart-sass engine on production systems.