search

bigcommerce / stencil-cli

BigCommerce Stencil emulator for local theme development
https://developer.bigcommerce.com/stencil-docs
BSD 4-Clause "Original" or "Old" License
102 stars 141 forks source link

Refactor getStoreChannels function #1187

Closed AndrewBarber closed 5 months ago

AndrewBarber commented 5 months ago

What?

Within getStoreChannels we fetch store channels, then filter them to access only storefront type channels. This can be made within the request, reducing the complexity of the codebase, as well as putting the processing on the server side.

Tickets / Documentation

N/A

Screenshots (if appropriate)

N/A

cc @bigcommerce/storefront-team

jairo-bc commented 5 months ago

Hi @AndrewBarber! Thanks for contributing to the project! Do you mind adding the type of the Pull Request into the title so it follows semantic commit convention? Also, would appreciate much some screenshots, how the changes were tested, if possible.

bc-jz commented 5 months ago

Hey @AndrewBarber ,

Thank you for this PR and the suggestions! I am including your changes into a PR I just made with updates to this same area: https://github.com/bigcommerce/stencil-cli/pull/1191

Just letting you know to save you time to updating your PR as it should no longer be needed.

bc-jz commented 5 months ago

Closing as we incorporated these changes into: https://github.com/bigcommerce/stencil-cli/pull/1191