bigcommerce / widget-builder

MIT License
18 stars 39 forks source link

Fixed consistency of the sequential execution symbol. #131

Closed KyleSmith0905 closed 10 months ago

KyleSmith0905 commented 1 year ago

What? Why?

While running the install-cli script on my computer, it showed an error. The error comes from the use of semicolons as a sequential execution symbol in the NPM script. Although this should work on most shells (source), it does not work on all.

I do not know if they was a specific reason for the use of the semicolon symbol as opposed to double ampersand, I was able to change the script in package.json to use the double ampersand and get it working.

I have: Windows - 11 PowerShell version - 5.1.22621.963 Node version - v18.15.0 NPM version - 9.5.0

Testing / Proof

Here is a copy of my command line as I was installing this without fixing the script.

PS C:\..\> git clone https://github.com/bigcommerce/widget-builder
Cloning into 'widget-builder'...
remote: Enumerating objects: 883, done.
remote: Counting objects: 100% (288/288), done.
remote: Compressing objects: 100% (178/178), done.
remote: Total 883 (delta 208), reused 139 (delta 109), pack-reused 595
Receiving objects: 100% (883/883), 659.51 KiB | 4.07 MiB/s, done.
Resolving deltas: 100% (434/434), done.
PS C:\..\> cd widget-builder
PS C:\..\widget-builder> npm run install-cli

> widget-builder@0.0.1 install-cli
> npm install; npm run build && npm install -g

Unknown command: "install;"

Did you mean one of these?
    npm install # Install a package
    npm uninstall # Remove a package

To see a list of supported npm commands, run:
  npm help
KyleSmith0905 commented 1 year ago

Just noticed this issue #94 that would be fixed with this fix.

christensenep commented 10 months ago

Apologies for the very slow response, but appreciate the contribution and the fix!