bigcy / tungsten-replicator

Automatically exported from code.google.com/p/tungsten-replicator
0 stars 0 forks source link

deprecate and remove trepctl {start|stop|shutdown|configure} #672

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
1. To which tool/application/daemon will this feature apply?

trepctl

2. Describe the feature in general

Remove some commands that are either unclear, obsolete, or duplicate of other 
functionalities

3. Describe the feature interface

remove the following commands

trepctl [-service xxx] start
 It starts one service, and requires the replicator to be already started. For most practical purposes, we can use 'trepctl online'

trepctl [-service xxx] stop
Stops a replication service. Notice that it does not stop the replicator. Other 
services will continue working.
The only reason for trepctl start/stop to be used is because they are used 
internally by 'trepctl configure' (see below)

trepctl [-service xxx] configure
This should be removed as it uses start/stop internally. The only reason for 
using configure is because, in earlier versions, we were editing the properties 
file and then restarting the replicator or running 'trepctl configure'. We now 
want to encourage users to run every change through tpm, because it is the 
cleanest way of implementing changes that will be preserved during upgrades.

trepctl shutdown

This command can be replaced by 'replicator stop'. The only advantage of 
'trepctl shutdown' is that it can stop a replicator remotely. Again, tpm can do 
that when needed.

trepctl [-service xxx] purge
See Issue#610. This command should be either re-implemented to do what it 
should do, or just removed.

4. Give an idea (if applicable) of a possible implementation

Deprecate the above commands in Tungsten Replicator 2.1.1 docs and help, and 
remove them in 2.1.2

5. Describe pros and cons of this feature.

5a. Why the world will be a better place with this feature.

Clearer help and docs, and less errors in operations.

5b. What hardship will the human race have to endure if this feature is
implemented.

We will probably need to answer some questions from concerned users

6. Notes

Original issue reported on code.google.com by g.maxia on 19 Aug 2013 at 9:39

GoogleCodeExporter commented 9 years ago
I'm not sure it's a good idea to remove the configure call, as it is used 
during development.

Original comment by linas.vi...@continuent.com on 19 Aug 2013 at 10:53

GoogleCodeExporter commented 9 years ago

Original comment by linas.vi...@continuent.com on 26 Aug 2013 at 1:54

GoogleCodeExporter commented 9 years ago
There won't be a 2.1.3.

Original comment by linas.vi...@continuent.com on 17 Sep 2013 at 10:13

GoogleCodeExporter commented 9 years ago
Let's just rename the following calls to avoid confusion, but leave 
versatility. We'll need to adjust JMX interfaces.

start - load
stop - unload

We shall remove:

shutdown - the only use case for this is to stop remote Replicator without SSH 
access.
purge - it doesn't work, use `tpm reset` instead.

We keep the configure call.

Original comment by linas.vi...@continuent.com on 15 Oct 2013 at 4:38

GoogleCodeExporter commented 9 years ago
Linas,

The `tpm reset` command should not be used for this. It resets everything 
across all nodes. I think you meant to say the `trepctl reset` command. It has 
been expanded with additional arguments to make it more usefule.

Original comment by jeff.m...@continuent.com on 15 Oct 2013 at 10:27

GoogleCodeExporter commented 9 years ago
These should be deprecated first, then removed in a future version. 

Original comment by mc.br...@continuent.com on 16 Oct 2013 at 7:45

GoogleCodeExporter commented 9 years ago

Original comment by linas.vi...@continuent.com on 16 Oct 2013 at 3:34

GoogleCodeExporter commented 9 years ago
trepctl shutdown and purge have been deprecated. Warning messages and simple 
suggestions added. We'll remove them in 2.2.1 (Issue 736).

Original comment by linas.vi...@continuent.com on 16 Oct 2013 at 3:36

GoogleCodeExporter commented 9 years ago
`trepctl start` renamed to `trepctl load`
`trepctl stop` renamed to `trepctl unload`

JMX methods renamed too:

startService(String name) -> loadService(String name)
stopService(String name) -> unloadService(String name)

See r1735 for all details.

This issue now needs final QA confirmation and then documenting.

Original comment by linas.vi...@continuent.com on 17 Oct 2013 at 10:51

GoogleCodeExporter commented 9 years ago
Deprecation of `trepctl purge` was incorrect. Undeprecate it.

Original comment by linas.vi...@continuent.com on 23 Oct 2013 at 3:15

GoogleCodeExporter commented 9 years ago
Provide a descriptive error message for deprecated command-line arguments that 
describe the replacement command if there is one, or simply the fact that it is 
deprecated, then exit with an error code.

Note for Documentation: missing load and unload in the manual

Original comment by eric.st...@continuent.com on 2 Dec 2013 at 2:11

GoogleCodeExporter commented 9 years ago
Descriptive messages added (r1903).

MC, it's left to you to update docs with load/unload.

Original comment by linas.vi...@continuent.com on 13 Dec 2013 at 3:08

GoogleCodeExporter commented 9 years ago
The documentation has been updated, and an entry has been added to the release 
notes: 

The following changes have been made to Tungsten Replicator and may affect 
existing scripts and integration tools. Any scripts or environment which make 
use of these tools should check and update for the new configuration:

 The following commands to trepctl have been deprecated and will be removed in a future release:
trepctl start has been replaced with trepctl load
trepctl stop has been replaced with trepctl unload
trepctl stop has been deprecated; use Section 2.20, “Starting and Stopping 
Tungsten Replicator” to stop the replicator.

Original comment by mc.br...@continuent.com on 16 Dec 2013 at 1:24

GoogleCodeExporter commented 9 years ago
This issue partially made it to CT 2.0.1:
r1735 - yes (core changes),
r1903 - no (helpful messages).

Original comment by linas.vi...@continuent.com on 27 Dec 2013 at 10:57