search

bigdaddydad / android-xbmcremote

Automatically exported from code.google.com/p/android-xbmcremote
0 stars 0 forks source link

TV Show Episode patch #386

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This patch contains:

- refactored Episode Details page
- Sort On options on TV Shows page
- sql query fix from issue 302

Original issue reported on code.google.com by Gabor.Fo...@gmail.com on 11 Sep 2010 at 2:46

Attachments:

GoogleCodeExporter commented 9 years ago 
Will have a look at the patch next week. Thanks.

Original comment by till.ess...@googlemail.com on 15 Sep 2010 at 8:19

GoogleCodeExporter commented 9 years ago 
Patch looking really good.
I would test it if eclipse won't always crash while building android projects...

One question: Why do you check the ThumbSize in the cache? Doesn't seem to be 
related to any of the other fixes.

Original comment by till.ess...@googlemail.com on 23 Sep 2010 at 11:56

GoogleCodeExporter commented 9 years ago 
I can't quite tell from the patch, but it would be extremely nice if the tv 
shows list hid shows with 0 episodes (not just 0 unwatched, but 0 total).

That's all.

Original comment by ehfis...@gmail.com on 24 Sep 2010 at 12:31

GoogleCodeExporter commented 9 years ago 
The patch is missing a drawable. And the changes in the 
AbstractManager#cacheCover() is causing a compile error.

Original comment by till.ess...@googlemail.com on 24 Sep 2010 at 9:57

GoogleCodeExporter commented 9 years ago 
Oh and the posterOverlay for the View is missing...

Original comment by till.ess...@googlemail.com on 24 Sep 2010 at 10:03

GoogleCodeExporter commented 9 years ago 
Oh crap. I have couple of patches piling up. Let me sort it out.
For the posterOverlay I have posted a patch in issue 234 earlier.

Original comment by Gabor.Fo...@gmail.com on 24 Sep 2010 at 10:52

GoogleCodeExporter commented 9 years ago 
Could you drop by in IRC on #xbmc-android? Query me (the_alien) and we can get 
rid of all those patches.

Original comment by till.ess...@googlemail.com on 24 Sep 2010 at 11:00

GoogleCodeExporter commented 9 years ago 
The missing part of the patch.txt

And it is also the answer for your question regarding the ThumbSize.
The DownloadThread#getCover checks if the thumb is exists in the disk cache, 
but the cache check in the DiskCacheThread#isInCache was always checking 
against the Medium size. Even if actually the small thumb is needed. That's why 
the thumbsize is passed.

Original comment by Gabor.Fo...@gmail.com on 24 Sep 2010 at 11:04

Attachments:

GoogleCodeExporter commented 9 years ago 
OK. Let's try this.

Original comment by Gabor.Fo...@gmail.com on 24 Sep 2010 at 12:54

Attachments:

GoogleCodeExporter commented 9 years ago 
Fixed with r696.

Original comment by till.ess...@googlemail.com on 24 Sep 2010 at 1:02