bigdata-ustc / EduKTM

The Model Zoo of Knowledge Tracing Models
Apache License 2.0
197 stars 63 forks source link

[BREAKING] fix some error in LPKT #14

Closed sone47 closed 3 years ago

sone47 commented 3 years ago

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

Description

(Brief description on what this PR is about)

What does this implement/fix? Explain your changes.

fix exercise id error, fix gamma in q-matrix, add k-fold cross validation

Pull request type

Changes

  1. fix LPKT performance not as expected caused by exercise id error
  2. fix gamma in q-matrix
  3. add k-fold cross validation

Does this close any currently open issues?

N/A

Any relevant logs, error output, etc?

N/A

Checklist

Before you submit a pull request, please make sure you have to following:

Essentials

Comments

codecov-commenter commented 3 years ago

Codecov Report

Merging #14 (f16620e) into main (f1009f1) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              main       #14    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           21        23     +2     
  Lines          870       982   +112     
==========================================
+ Hits           870       982   +112     
Impacted Files Coverage Δ
EduKTM/LPKT/LPKT.py 100.00% <100.00%> (ø)
EduKTM/LPKT/LPKTNet.py 100.00% <100.00%> (ø)
EduKTM/KPT/KPT.py 100.00% <0.00%> (ø)
EduKTM/__init__.py 100.00% <0.00%> (ø)
EduKTM/EKPT/__init__.py 100.00% <0.00%> (ø)
EduKTM/EKPT/EKPT.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1009f1...f16620e. Read the comment docs.