bigdata-ustc / EduKTM

The Model Zoo of Knowledge Tracing Models
Apache License 2.0
197 stars 63 forks source link

[FEATURE] Add KPT/EKPT Model #2

Closed Ljyustc closed 3 years ago

Ljyustc commented 3 years ago

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

Description

Add KPT and EKPT model

What does this implement/fix? Explain your changes.

Add KPT/EKPT model

Pull request type

Changes

  1. Add KPT/EKPT model
  2. Add KPT/EKPT examples
  3. Add KPT/EKPT doc
  4. Add tests for KPT/EKPT

Does this close any currently open issues?

N/A

Any relevant logs, error output, etc?

N/A

Checklist

Before you submit a pull request, please make sure you have to following:

Essentials

Comments

tswsxk commented 3 years ago
  1. tqdm dependency is missed, please add dependencies in setup.py
tswsxk commented 3 years ago
  1. I notice that your example code, more specifically, the script version and notebook version are not exactly equivment. I suggest that you move the data preprocessing code in your notebook to the prepare_dataset.py, otherwise people cannot run your script until they run the notebook.
codecov-commenter commented 3 years ago

Codecov Report

Merging #2 (a982964) into main (23d9610) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              main        #2    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            1         4     +3     
  Lines            6       119   +113     
==========================================
+ Hits             6       119   +113     
Impacted Files Coverage Δ
EduKTM/KPT/KPT.py 100.00% <100.00%> (ø)
EduKTM/KPT/__init__.py 100.00% <100.00%> (ø)
EduKTM/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23d9610...a982964. Read the comment docs.