bigdata-ustc / EduKTM

The Model Zoo of Knowledge Tracing Models
Apache License 2.0
197 stars 63 forks source link

[BUGFIX] fix batch_size=1 error in DKT & name used wrongly in AKT #27

Closed sone47 closed 2 years ago

sone47 commented 2 years ago

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

Description

(Brief description on what this PR is about)

What does this implement/fix? Explain your changes.

...

Pull request type

Changes

Does this close any currently open issues?

DKT training fails for batch size of 1

Any relevant logs, error output, etc?

NA

Checklist

Before you submit a pull request, please make sure you have to following:

Essentials

Comments

codecov-commenter commented 2 years ago

Codecov Report

Merging #27 (ffcfef1) into main (e973d1a) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   99.14%   99.14%   -0.01%     
==========================================
  Files          30       30              
  Lines        1518     1517       -1     
==========================================
- Hits         1505     1504       -1     
  Misses         13       13              
Impacted Files Coverage Δ
EduKTM/AKT/AKT.py 100.00% <100.00%> (ø)
EduKTM/DKT/DKT.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e973d1a...ffcfef1. Read the comment docs.