search

bigdataviewer / bigdataviewer-core

ImgLib2-based viewer for registered SPIM stacks and more
BSD 2-Clause "Simplified" License
33 stars 35 forks source link

TransformedBoxEditor potential bug #100

Open tischi opened 4 years ago

tischi commented 4 years ago

@tpietzsch

I could swear I posted this issue already somewhere, but now I cannot find, so I post it again.

Here: https://github.com/bigdataviewer/bigdataviewer-core/blob/master/src/main/java/bdv/tools/boundingbox/TransformedBoxEditor.java#L285

This crashes if the current bindings do not contain the moveCornerTrigger, because bindings.get( t ) returns null.

For me, below fix appears to work, but maybe I am overlooking something?

for ( final InputTrigger t : moveCornerTriggers )
{
    if ( bindings.containsKey( t ) )
            behavioursToBlock.addAll( bindings.get( t ) );
}