POM: update parent to pom-scijava-29.2.0

imagejan commented 4 years ago

Remove hard-coded versions as well as overridden version properties.

Fixes https://github.com/fiji/fiji/issues/256.

/cc @tischi

imagejan commented 4 years ago

Some more background:

The issue was that bigdataviewer-core-9.0.5 was compiled against scijava-listeners-1.0.0-beta-2, while an up-to-date Fiji installation shipped scijava-listeners-1.0.0-beta-3.

While the beta-2 and beta-3 source code versions seem to be compatible, they aren't on a compiled (byte-code) level. The relevant change is:

-       public final ArrayList< T > list = new ArrayList<>();
+       public final java.util.List< T > list;

(see diff)

The compiled code of bigdataviewer-core was looking for an ArrayList list, whereas scijava-listeners-1.0.0-beta-3 only provides List list.

Edit: Note that this issue wasn't detected by the mega-melt in pom-scijava because the <version> was hard-coded in the POM, instead of being defined using a version <property> (and scijava-listeners is managed in pom-scijava since recently only).

imagesc-bot commented 4 years ago

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/bigstitcher-wont-open-a-xml-hdf5-dataset-after-resaving/41206/9

ctrueden commented 4 years ago

@imagejan wrote:

Note that this issue wasn't detected by the mega-melt in pom-scijava because the was hard-coded in the POM

Right on. Great detective work, @imagejan. Thanks for the PR. Merging!

imagesc-bot commented 4 years ago

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/update-in-fiji-causing-issue-using-big-warp/41164/4

imagesc-bot commented 3 years ago

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/labkit-import-labeling-bitmap/44069/6

bigdataviewer / bigdataviewer-core

POM: update parent to pom-scijava-29.2.0 #103